Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dubbo admin console dispaly error in https://github.com/alibaba/… #780

Merged
merged 11 commits into from
Dec 6, 2017
Merged

fix dubbo admin console dispaly error in https://github.com/alibaba/… #780

merged 11 commits into from
Dec 6, 2017

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Oct 25, 2017 •
edited
Loading

修改 #714 governance/screen/providers/providers页面，对于服务“重复”的错误提示

因为是页面修改，只能手动功能测试

一、问题：多个应用的服务列表页面警告异常（100%重现）

   DUBBO_ADMIN_HOST/governance/screen/providers/providers

错误页面：
image
（图片一）

二、查看代码逻辑有问题，

#if($providerApplication != $provider.application)  
            #if ($errorLevel != "error") #set($errorLevel = "warn") #end  
            #set($errorMessage = "$errorMessage<br>$i18n.get('warn'): $i18n.get('CheckProviderApplicationDifferent', $providerApplication, $provider.application)")  
#end 

    当判断providerApplication的值和provider.application的值不相同时就给出警告。就成为只要应用名和第一个遍历出来的不一样就加警告。
   需求是：不同应用发了相同服务页面警报。
   修改后就好了。

三、代码修改后前后问题的验证和回归：

1、列表中，不同应用没有提供相同服务，页面修改前后：

错误页面：
见（图片一）

修改后页面：
image
问题已经修复

2、列表中多个应用，有提供相同服务的（页面应该报警）。

image
回归发现功能仍然正确

请 @chickenlj 合并一下代码

@lovepoem lovepoem mentioned this pull request Oct 26, 2017
Closed
@lovepoem lovepoem mentioned this pull request Oct 29, 2017
Closed
@chickenlj chickenlj merged commit a3c8c62 into apache:master Dec 6, 2017
@lovepoem lovepoem deleted the fix_714_dubbo_admin_console_notice_error_display branch December 7, 2017 05:16
@lovepoem lovepoem mentioned this pull request Dec 20, 2017
Closed
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
@lovepoem @chickenlj
Merge pull request apache#780, fix dubbo admin console display error
9e7e9c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovepoem @chickenlj